Skip to content

[SW-2808] Send camera calibrations to spot - #178

Merged
tcappellari-bdai merged 25 commits into
mainfrom
feature/set_camera_calib_test
Sep 8, 2025
Merged

[SW-2808] Send camera calibrations to spot#178
tcappellari-bdai merged 25 commits into
mainfrom
feature/set_camera_calib_test

Conversation

@tcappellari-bdai

@tcappellari-bdai tcappellari-bdai commented Aug 29, 2025

Copy link
Copy Markdown
Collaborator

The release of Spot SDK 5.0.0 allows users to send the hand camera calibration to spot and get back data that reflects that

I added a flag -send that will save the calibration data to the robot.
I was testing with the following command on Opal

python calibrate_spot_hand_camera_cli.py -i 10.17.30.34 -u user -pw bbbdddaaaiii -l True -sd -rp test_result.yaml -dp temp_data/ --photo_utilization_ratio 1 --stereo_pairs "[(1,0)]" --legacy_charuco_pattern True --spot_rgb_photo_width=640 --spot_rgb_photo_height=480 --tag default -send

@coveralls

coveralls commented Aug 29, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 17562161853

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 76 (0.0%) changed or added relevant lines in 4 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.5%) to 44.399%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spot_wrapper/calibration/calibrate_multistereo_cameras_with_charuco_cli.py 0 6 0.0%
spot_wrapper/calibration/calibrate_spot_hand_camera_cli.py 0 12 0.0%
spot_wrapper/calibration/calibration_util.py 0 12 0.0%
spot_wrapper/calibration/spot_in_hand_camera_calibration.py 0 46 0.0%
Files with Coverage Reduction New Missed Lines %
spot_wrapper/calibration/calibrate_multistereo_cameras_with_charuco_cli.py 1 0.0%
spot_wrapper/calibration/calibrate_spot_hand_camera_cli.py 1 0.0%
spot_wrapper/calibration/calibration_util.py 1 0.0%
spot_wrapper/calibration/spot_in_hand_camera_calibration.py 2 0.0%
Totals Coverage Status
Change from base Build 17469429527: -0.5%
Covered Lines: 2192
Relevant Lines: 4937

💛 - Coveralls

Comment thread spot_wrapper/calibration/spot_in_hand_camera_calibration.py Outdated
@tcappellari-bdai
tcappellari-bdai marked this pull request as ready for review September 8, 2025 18:33
@jcarpinelli-bdai
jcarpinelli-bdai self-requested a review September 8, 2025 18:43
Comment thread spot_wrapper/calibration/calibrate_multistereo_cameras_with_charuco_cli.py Outdated
Comment thread spot_wrapper/calibration/calibrate_multistereo_cameras_with_charuco_cli.py Outdated
Comment thread spot_wrapper/calibration/calibration_util.py Outdated
Comment thread spot_wrapper/calibration/spot_in_hand_camera_calibration.py
Comment thread spot_wrapper/calibration/README.md
Comment thread spot_wrapper/calibration/calibration_util.py Outdated
Comment thread spot_wrapper/calibration/calibration_util.py Outdated

@khughes-bdai khughes-bdai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you've gotten it working on robot 🎉
Just left a few minor clean up comments, my one main request would just be to add a few sentences to the readme that mentions that you can now save the calibration to the robot

@tcappellari-bdai
tcappellari-bdai merged commit 97971cc into main Sep 8, 2025
3 checks passed
@tcappellari-bdai
tcappellari-bdai deleted the feature/set_camera_calib_test branch September 8, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants