[SW-2808] Send camera calibrations to spot - #178
Merged
Conversation
Pull Request Test Coverage Report for Build 17562161853Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
khughes-bdai
reviewed
Sep 2, 2025
tcappellari-bdai
marked this pull request as ready for review
September 8, 2025 18:33
tcappellari-bdai
requested review from
heuristicus and
mhidalgo-rai
as code owners
September 8, 2025 18:33
jcarpinelli-bdai
self-requested a review
September 8, 2025 18:43
khughes-bdai
reviewed
Sep 8, 2025
khughes-bdai
reviewed
Sep 8, 2025
khughes-bdai
reviewed
Sep 8, 2025
khughes-bdai
reviewed
Sep 8, 2025
khughes-bdai
reviewed
Sep 8, 2025
khughes-bdai
reviewed
Sep 8, 2025
khughes-bdai
reviewed
Sep 8, 2025
khughes-bdai
approved these changes
Sep 8, 2025
khughes-bdai
left a comment
Contributor
There was a problem hiding this comment.
LGTM if you've gotten it working on robot 🎉
Just left a few minor clean up comments, my one main request would just be to add a few sentences to the readme that mentions that you can now save the calibration to the robot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release of Spot SDK 5.0.0 allows users to send the hand camera calibration to spot and get back data that reflects that
I added a flag
-sendthat will save the calibration data to the robot.I was testing with the following command on Opal