[SW-3698] Send spot hand calibration from yaml - #183
Merged
Conversation
tcappellari-bdai
requested review from
heuristicus,
khughes-bdai and
mhidalgo-rai
as code owners
September 24, 2025 17:33
tcappellari-bdai
requested review from
a team,
bjin-bdai,
jbarnett-bdai,
jcarpinelli-bdai,
mbrauckmann-bdai,
mgoh-bdai and
mvictora-bdai
September 24, 2025 17:33
Pull Request Test Coverage Report for Build 17986548573Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
mvictora-bdai
left a comment
There was a problem hiding this comment.
Looks good to me, minus a leftover unused commented line of code
khughes-bdai
approved these changes
Sep 24, 2025
khughes-bdai
left a comment
Contributor
There was a problem hiding this comment.
+1 to michelle's comment but otherwise LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to send spot new hand camera calibrations from a previously computed yaml file. Just add the
-yamlor--from_yamlflag when running the calibration script and it will use your provided data path to the yaml (include data path with-dpflag)