Skip to content

[SW-3698] Send spot hand calibration from yaml - #183

Merged
tcappellari-bdai merged 3 commits into
mainfrom
tcapp/send_calibration_from_yaml
Sep 24, 2025
Merged

[SW-3698] Send spot hand calibration from yaml#183
tcappellari-bdai merged 3 commits into
mainfrom
tcapp/send_calibration_from_yaml

Conversation

@tcappellari-bdai

Copy link
Copy Markdown
Collaborator

Added the ability to send spot new hand camera calibrations from a previously computed yaml file. Just add the -yaml or --from_yaml flag when running the calibration script and it will use your provided data path to the yaml (include data path with -dp flag)

@coveralls

coveralls commented Sep 24, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 17986548573

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 15 (0.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 44.314%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spot_wrapper/calibration/calibrate_multistereo_cameras_with_charuco_cli.py 0 1 0.0%
spot_wrapper/calibration/spot_in_hand_camera_calibration.py 0 1 0.0%
spot_wrapper/calibration/calibrate_spot_hand_camera_cli.py 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
spot_wrapper/calibration/calibrate_spot_hand_camera_cli.py 1 0.0%
Totals Coverage Status
Change from base Build 17913869663: -0.1%
Covered Lines: 2194
Relevant Lines: 4951

💛 - Coveralls

Comment thread spot_wrapper/calibration/calibrate_spot_hand_camera_cli.py Outdated

@mvictora-bdai mvictora-bdai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, minus a leftover unused commented line of code

@khughes-bdai khughes-bdai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to michelle's comment but otherwise LGTM!

@tcappellari-bdai
tcappellari-bdai merged commit 4705eb1 into main Sep 24, 2025
3 checks passed
@tcappellari-bdai
tcappellari-bdai deleted the tcapp/send_calibration_from_yaml branch September 24, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants