Merge pull request #821 from rails-sqlserver/enable-frozen-strings-part-1

wpolicarpo · web-flow · commit 019d71235eab · 2020-05-14T10:55:09.000+01:00
Enable frozen strings - part 1
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@
 - [#763](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/763) Refactor columns introspection query to make it faster
 - [#783](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/783) Update test matrix
 - [#820](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/820) Enable frozen strings for tests
+- [#821](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/821) Enable frozen strings - part 1
 
 #### Added
 
diff --git a/Rakefile b/Rakefile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rake/testtask'
 require_relative 'test/support/paths_sqlserver'
diff --git a/lib/active_record/connection_adapters/sqlserver/core_ext/active_record.rb b/lib/active_record/connection_adapters/sqlserver/core_ext/active_record.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
diff --git a/lib/active_record/connection_adapters/sqlserver/core_ext/attribute_methods.rb b/lib/active_record/connection_adapters/sqlserver/core_ext/attribute_methods.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_record/attribute_methods'
 
 module ActiveRecord
diff --git a/lib/active_record/connection_adapters/sqlserver/core_ext/calculations.rb b/lib/active_record/connection_adapters/sqlserver/core_ext/calculations.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_record/relation'
 require 'active_record/version'
 
diff --git a/lib/active_record/connection_adapters/sqlserver/core_ext/explain.rb b/lib/active_record/connection_adapters/sqlserver/core_ext/explain.rb
@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module CoreExt
         module Explain
 
-          SQLSERVER_STATEMENT_PREFIX = 'EXEC sp_executesql '.freeze
+          SQLSERVER_STATEMENT_PREFIX = 'EXEC sp_executesql '
           SQLSERVER_STATEMENT_REGEXP = /N'(.+)', N'(.+)', (.+)/
 
           def exec_explain(queries)
diff --git a/lib/active_record/connection_adapters/sqlserver/core_ext/explain_subscriber.rb b/lib/active_record/connection_adapters/sqlserver/core_ext/explain_subscriber.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ActiveSupport.on_load(:active_record) do
   silence_warnings do
     # Already defined in Rails
diff --git a/lib/active_record/connection_adapters/sqlserver/core_ext/finder_methods.rb b/lib/active_record/connection_adapters/sqlserver/core_ext/finder_methods.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_record/relation'
 require 'active_record/version'
 
diff --git a/lib/active_record/connection_adapters/sqlserver/core_ext/preloader.rb b/lib/active_record/connection_adapters/sqlserver/core_ext/preloader.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_record/associations/preloader"
 
 module ActiveRecord
diff --git a/lib/active_record/connection_adapters/sqlserver/core_ext/query_methods.rb b/lib/active_record/connection_adapters/sqlserver/core_ext/query_methods.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_record/relation'
 require 'active_record/version'
 
diff --git a/lib/active_record/connection_adapters/sqlserver/showplan/printer_table.rb b/lib/active_record/connection_adapters/sqlserver/showplan/printer_table.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
diff --git a/lib/active_record/connection_adapters/sqlserver/showplan/printer_xml.rb b/lib/active_record/connection_adapters/sqlserver/showplan/printer_xml.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
diff --git a/test/cases/column_test_sqlserver.rb b/test/cases/column_test_sqlserver.rb
@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 
-# encoding: UTF-8
 require 'cases/helper_sqlserver'
 
 class ColumnTestSQLServer < ActiveRecord::TestCase
diff --git a/test/cases/transaction_test_sqlserver.rb b/test/cases/transaction_test_sqlserver.rb
@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 
-# encoding: UTF-8
 require 'cases/helper_sqlserver'
 require 'models/ship'
 require 'models/developer'
diff --git a/test/cases/trigger_test_sqlserver.rb b/test/cases/trigger_test_sqlserver.rb
@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 
-# encoding: UTF-8
 require 'cases/helper_sqlserver'
 
 class SQLServerTriggerTest < ActiveRecord::TestCase
diff --git a/test/cases/uuid_test_sqlserver.rb b/test/cases/uuid_test_sqlserver.rb
@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 
-# encoding: UTF-8
 require 'cases/helper_sqlserver'
 
 class SQLServerUuidTest < ActiveRecord::TestCase

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require 'bundler/gem_tasks'`
`2`	`4`	`require 'rake/testtask'`
`3`	`5`	`require_relative 'test/support/paths_sqlserver'`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`module ActiveRecord`
`2`	`4`	`module ConnectionAdapters`
`3`	`5`	`module SQLServer`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require 'active_record/attribute_methods'`
`2`	`4`
`3`	`5`	`module ActiveRecord`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require 'active_record/relation'`
`2`	`4`	`require 'active_record/version'`
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`ActiveSupport.on_load(:active_record) do`
`2`	`4`	`silence_warnings do`
`3`	`5`	`# Already defined in Rails`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require "active_record/associations/preloader"`
`2`	`4`
`3`	`5`	`module ActiveRecord`