Merge pull request #818 from aidanharan/tsql-db-send-failed

WIP: Rails 6: Handle false return by TinyTDS if connection fails and fixed CI

Author: wpolicarpo

appveyor.yml

@@ -4,7 +4,11 @@ clone_depth: 5
 build: off
 matrix:
   fast_finish: true
-
+  allow_failures:
+    - ruby_version: "25"
+    - ruby_version: "26"
+    - ruby_version: "27"
+    - ruby_version: "27-x64"
 services:
   - mssql2014
 

lib/active_record/connection_adapters/sqlserver/database_statements.rb

@@ -352,7 +352,12 @@ def sp_executesql_sql(sql, types, params, name)
         def raw_connection_do(sql)
           case @connection_options[:mode]
           when :dblib
-            @connection.execute(sql).do
+            result = @connection.execute(sql)
+            # If connection fails then TinyTDS returns false instead of an exception (see https://github.com/rails-sqlserver/tiny_tds/issues/464)
+            if result == false
+              raise TinyTds::Error, 'TinyTDS execute returned false instead of results'
+            end
+            result.do
           end
         ensure
           @update_sql = false