Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly retrieve the SQL Server database version #1313

Merged
merged 5 commits into from
Mar 20, 2025
Merged

Correctly retrieve the SQL Server database version #1313

merged 5 commits into from
Mar 20, 2025

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Mar 19, 2025 •
edited
Loading

An exception was being silently thrown when getting the database version, and then defaulting to 2016.

In this PR:

  • Fix the bug when retrieving the database version
  • Stops the exception from being silently swallowed in future
  • Outputs the database version after each test run to help debugging

@aidanharan aidanharan marked this pull request as ready for review March 20, 2025 15:51
@aidanharan aidanharan changed the title Correctly parse the database version Correctly retrieve the SQL Server database version Mar 20, 2025
@aidanharan aidanharan merged commit 2e23939 into main Mar 20, 2025
9 of 10 checks passed
@aidanharan aidanharan deleted the fix-database-version branch March 20, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aidanharan