Make DEFAULT_LOCATOR Configurable#179
Merged
rafaelfranca merged 1 commit intorails:mainfrom Sep 17, 2025
Merged
Conversation
default_locator as configurableDEFAULT_LOCATOR Configurable
Contributor
Author
There are some unrelated CI issues that should be handled in a separate PR. I'll take care of them when I have time. |
Contributor
Author
|
Hi, @rafaelfranca. Could you give me a feedback when you have a time? |
Contributor
|
@heka1024 I think you can rebase these changes, and tests may all pass? |
6966d15 to
5ed7420
Compare
Contributor
Author
|
@olleolleolle All tests are passing now. Appreciate the help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my application, I want all select query from
GlobalID::Locatorto come from the read only database, but I can't modify theDEFAULT_LOCATOR, so I made it configurable. I think it's more in line with the Rails philosophy to make this customizable, not just for my use case.Any feedback or suggestions would be greatly appreciated!