Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make multiline importmap definitions work with importmap outdated for instance #256

Closed
wants to merge 2 commits into from
Closed

make multiline importmap definitions work with importmap outdated for instance #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e28034c
make multiline importmap definitions work with `importmap outdated` f…
dorianmariecom Jul 19, 2024
4b126f6
inversed the outdated and updates :facepalm:
dorianmariecom Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/importmap/npm.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ def packages_with_versions
# We cannot use the name after "pin" because some dependencies are loaded from inside packages
# Eg. pin "buffer", to: "https://ga.jspm.io/npm:@jspm/[email protected]/nodelibs/browser/buffer.js"

importmap.scan(/^pin .*(?<=npm:|npm\/|skypack\.dev\/|unpkg\.com\/)(.*)(?=@\d+\.\d+\.\d+)@(\d+\.\d+\.\d+(?:[^\/\s["']]*)).*$/) |
importmap.scan(/^pin ["']([^["']]*)["'].* #.*@(\d+\.\d+\.\d+(?:[^\s]*)).*$/)
importmap.scan(/pin .*(?<=npm:|npm\/|skypack\.dev\/|unpkg\.com\/)(.*)(?=@\d+\.\d+\.\d+)@(\d+\.\d+\.\d+(?:[^\/\s["']]*)).*/m) |
importmap.scan(/pin ["']([^["']]*)["'].* #.*@(\d+\.\d+\.\d+(?:[^\s]*)).*/m)
end

private
Expand Down
2 changes: 2 additions & 0 deletions test/fixtures/files/multiline_outdated_import_map.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
ipin "intl-tel-input/build/js/utils.js",
to: "intl-tel-input--build--js--utils.js.js" # @23.3.2
2 changes: 2 additions & 0 deletions test/fixtures/files/multiline_updated_import_map.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
ipin "intl-tel-input/build/js/utils.js",
to: "intl-tel-input--build--js--utils.js.js" # @23.5.0
24 changes: 24 additions & 0 deletions test/npm_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,30 @@ class Importmap::NpmTest < ActiveSupport::TestCase
end
end

test "successful outdated packages using multiple lines" do
npm = Importmap::Npm.new(file_fixture("multiline_outdated_import_map.rb"))
response = { "dist-tags" => { "latest" => '23.5.0' } }.to_json

npm.stub(:get_json, response) do
outdated_packages = npm.outdated_packages

assert_equal(1, outdated_packages.size)
assert_equal('intl-tel-input/build/js/utils.js', outdated_packages[0].name)
assert_equal('23.3.2', outdated_packages[0].current_version)
assert_equal('23.5.0', outdated_packages[0].latest_version)
end
end

test "successful updarted packages using multiple lines" do
npm = Importmap::Npm.new(file_fixture("multiline_updated_import_map.rb"))
response = { "dist-tags" => { "latest" => '23.5.0' } }.to_json

npm.stub(:get_json, response) do
outdated_packages = npm.outdated_packages
assert_equal(0, outdated_packages.size)
end
end

test "missing outdated packages with mock" do
response = { "error" => "Not found" }.to_json

Expand Down
Loading