Add dependency on minitest-mock for MT6 compatibility#211
Closed
voxik wants to merge 1 commit intorails:mainfrom
Closed
Add dependency on minitest-mock for MT6 compatibility#211voxik wants to merge 1 commit intorails:mainfrom
voxik wants to merge 1 commit intorails:mainfrom
Conversation
Author
|
Please see https://github.com/rails/rails-html-sanitizer/actions/runs/20606018257 for examples of the test failures |
This prevents test errors with minitest 6+ such as:
~~~
1) Error:
RailsApiTest#test_best_supported_vendor_when_html5_is_not_supported_returns_html4:
NoMethodError: undefined method 'stub' for class Rails::HTML::Sanitizer
test/rails_api_test.rb:21:in 'RailsApiTest#test_best_supported_vendor_when_html5_is_not_supported_returns_html4'
2) Error:
RailsApiTest#test_best_supported_vendor_when_html5_is_supported_returns_html5:
NoMethodError: undefined method 'stub' for class Rails::HTML::Sanitizer
test/rails_api_test.rb:29:in 'RailsApiTest#test_best_supported_vendor_when_html5_is_supported_returns_html5'
~~~
This is due to minitest-mock being extracted from Minitest 6+:
minitest/minitest@de9aac1
Please note that the condition is in this way, because MT6 restrict
upport to Ruby 3.2+ [[1], [2]]
[1]: minitest/minitest-mock#4
[2]: minitest/minitest#1058
Member
|
Sorry, I fixed this in #213 before I saw your PR. |
Author
|
No worries. But would you please reconsider approach suggested by this PR, which actually encourages use of newer MT instead of sticking with older version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents test errors with minitest 6+ such as:
This is due to minitest-mock being extracted from Minitest 6+:
minitest/minitest@de9aac1
Please note that the condition is in this way, because MT6 restrict upport to Ruby 3.2+ [1, 2]