Bump minimum rubocop gem version to 1.74.0 to pick up redundant plugin loading bug fix
#35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RuboCop plugin system introduced in 1.72.0, which improves the way of using additional cop gems such as rubocop-rails, had a bug in which linting runs could fail due to RuboCop trying to load additional cop gems via both the new plugins system and the original requires system. An example of said error which caused CI to fail is as follows. ([CI logs](https://github.com/larouxn/rails_8_store/actions/runs/15054427243/job/42316854789#step:4:1)) ```console Run bin/rubocop -f github Error: `Performance` cops have been extracted to the `rubocop-performance` gem. (obsolete configuration found in vendor/bundle/ruby/3.4.0/gems/rubocop-rails-omakase-1.1.0/rubocop.yml, please update it) `Rails` cops have been extracted to the `rubocop-rails` gem. (obsolete configuration found in vendor/bundle/ruby/3.4.0/gems/rubocop-rails-omakase-1.1.0/rubocop.yml, please update it) ``` Thankfully this appears to have been fixed in [1.74.0](https://github.com/rubocop/rubocop/releases/tag/v1.74.0), specifically in [rubocop/rubocop#13981](rubocop/rubocop#13981). Thus, I'm proposing to bump the minimum required version of the rubocop gem to 1.74.0 in order to automatically prevent the above issue. Noting, the workaround for this issue is to manually upgrade the rubocop gem to 1.74.0 or later, though this will not happened automatically via, for example, Dependabot.
Merged
|
sound reasonable. 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RuboCop plugin system introduced in 1.72.0, which improves the way of using additional cop gems such as
rubocop-rails, had a bug in which linting runs could fail due to RuboCop trying to load additional cop gems via both the new plugins system and the original requires system. An example of said error which caused CI to fail is as follows. (CI logs)Thankfully this appears to have been fixed in 1.74.0, specifically in rubocop/rubocop#13981. Thus, I'm proposing to bump the minimum required version of the
rubocopgem to 1.74.0 in order to automatically prevent the above issue.Noting, the workaround for this issue is to manually upgrade the
rubocopgem to 1.74.0 or later. However, this will not happened automatically via, for example, Dependabot and therefore is pretty surprising/unintuitive/non-omakase.Follow up to #28