Make sure jobs claimed are those claimed for the given process ID #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And not another process claiming the same jobs, since the INSERT query in the claimed_executions table would ignore any duplicates on job_id.
…ates The name `lock` alone was confusing because it's the same as ActiveRecord's lock method, and `candidates` was a bit ambiguous, easy to say explicitly that the candidates are job IDs.
rosa
force-pushed
the
claim-claimed-jobs
branch
from
1464357 to
7ffbb40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And not another process claiming the same jobs, since the
INSERTquery in theclaimed_executionstable would ignore any duplicates onjob_id. Moreover, make thatINSERTfail when there are any duplicates, so we get some visibility on how this might be happening.This is a guard for a supposedly impossible situation described in this card, that I haven't managed to explain. It shouldn't harm in any case.