DUPLICATE: MorphicCore Unit Tests for Mac client #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added tests for a new Preferences instance - Added tests for non-existent preference - Improved test for keyValueTuples Note: test for remove(key:) still fails
- PreferencesTests: Since keys implement Equatable, used '==' to compare them. - StorageTests: Used guard-with-constant insted of if to check for nil.
- fixed Storage tests to handle asynchronous saving and loading, - added minimal test for loading default preferences as created by the application
- modifed Storage load() tests due to change in load() signature - added test for contains() when it returns false
|
Closing as this is now tracked by #51 |
christopher-rtf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically a work in progress or draft pull request. But, @kaspermarkus suggested making it official in order to get feedback.
@owenpshaw or @christopher-rtf could you have a look? I chose writing tests as a way to familiarize myself with the code, XCode, and the testing framework. The tests herein revealed two bugs that I've fixed:
emailinUser.swiftremove()function inPreferences.swiftMore tests to come.
JIRA: https://morphic.atlassian.net/browse/MOR-103