Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't raise error when service call fails #116

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Don't raise error when service call fails #116

merged 1 commit into from
Mar 27, 2024

Conversation

raman325
Copy link
Owner

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

@github-actions github-actions bot added bug Something isn't working python Pull requests that update Python code labels Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.97%. Comparing base (086e888) to head (b2028f7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   89.82%   89.97%   +0.14%     
==========================================
  Files          19       19              
  Lines        1209     1207       -2     
==========================================
  Hits         1086     1086              
+ Misses        123      121       -2     
Files Coverage Δ
...om_components/lock_code_manager/providers/_base.py 80.16% <ø> (+1.30%) ⬆️

@raman325 raman325 merged commit 77db884 into main Mar 27, 2024
9 checks passed
@raman325 raman325 deleted the error branch March 27, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant