-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix config flow for multiple locks #49
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
=======================================
Coverage 89.51% 89.52%
=======================================
Files 19 19
Lines 1192 1193 +1
=======================================
+ Hits 1067 1068 +1
Misses 125 125
|
Does not appear to have completely fixed the problem. I'm getting less spew but still getting something:
Current test configuration: LCM Bob (why because Bob sounded good this time 😄 ) configured with slots 1 - 3. Slot 1 is configured completely manually, Slot 2 has a calendar attached to it, Slot 3 has a different calendar attached to it. LCM is configured to use lock.test_lock I verified that everything is working correctly. I then added Foo configured to use lock.test_lock and configured slots 5 - 7, all configured manually. I get the above error after adding it. It shows up as no devices or entities configured, it does however let me pull up the configuration now, which it wasn't doing before. Removing this one gives me the following error:
Removing the working one (after removing the one that failed) gives no errors. |
how about now @tykeal ? |
@raman325 That works great :) |
This should fix #48
@tykeal can you confirm?