Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Theme Toggle #290

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jktravis
Copy link

The dark theme that was added causes strain on some people just like the light theme for others. Prior work was done to try and use the user's system preferences. But for me, I want my system set to dark, and things that require a fair amount of reading to light for easier reading. Additionally, the current implementation never seemed to respect my settings.

Maybe we should add a theme toggle instead. This theme can be stored in local storage so it will persist.

The toggle here is placed in the top-right corner.

icon-location

Light and dark look the same on toggle.

@kedashoe
Copy link
Contributor

ty for the PR @jktravis

Only issue I see it the version dropdown is really hard to see

Current version:
current

With these changes:
after

@jktravis
Copy link
Author

Weird. Mine looks like this in all cases.

image

I'll see if I can figure out a change.

Thanks.

@yurkimus
Copy link
Contributor

yurkimus commented Jan 11, 2025

What about system theme?

I never using any toggles related to color scheme and always use "system" approach.

@jktravis
Copy link
Author

Can that be overridden? I have two issues that I'd like to solve:

  1. it doesn't seem to apply correctly in Firefox (I've tried several different setting permutations between FF and OS).
example
  1. I use dark on my system for most things, but for just text and reading, I find it more difficult with dark mode. For instance, I prefer my mail client to use the darker window borders and such, but he email itself, I need it to be light.

By implementing a toggle of some sort, we can accommodate all personal preferences.

I just didn't know how to implement a toggle while also respecting the color-scheme. If you're familiar with integrating the two, I'd be happy to work with you on it. Feel free to update what I have.

@jktravis jktravis force-pushed the feature/add-theme-toggle branch from 4f288bf to 24f70b6 Compare January 13, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants