prometheus-adapter Nodeselector fix #4775
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
skanakal
force-pushed
the
nodeselector-fix
branch
from
f0de58c to
73cbba3
Compare
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
skanakal
force-pushed
the
nodeselector-fix
branch
from
73cbba3 to
8a6f3c4
Compare
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
skanakal
force-pushed
the
nodeselector-fix
branch
from
8a6f3c4 to
847cf36
Compare
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
skanakal
force-pushed
the
nodeselector-fix
branch
from
847cf36 to
5907dc1
Compare
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
alexandreLamarre
requested changes
Feb 3, 2025
| @@ -1,7 +1,7 @@ | |||
| url: https://github.com/prometheus-community/helm-charts.git | |||
| subdirectory: charts/kube-prometheus-stack | |||
| commit: 2ee818aaae56fd93d27652e6d878e15140636aaf | |||
| version: 105.1.2 | |||
| version: 105.1.3 | |||
There was a problem hiding this comment.
We should instead bump these to 105.1.3-rc.1 for testing by QA, otherwise looks good
There was a problem hiding this comment.
@alexandreLamarre I have changed as per your suggestion...
|
We need to also target dev-v2.11 first for testing I can open this PR 👍 |
skanakal
force-pushed
the
nodeselector-fix
branch
from
5907dc1 to
137e834
Compare
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
rancher/rancher#48089
Problem
Solution
Testing
Engineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
Regressions Considerations
Backporting considerations