Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.8] harvester-csi-driver 103.0.6+up0.1.23 bump #5086

Conversation

Vicente-Cheng
Copy link
Contributor

Pull Requests Rules

  • Never remove an already released chart!

    • This does not apply to RC's because they are not released.
  • Each Pull Request should only modify one chart with its dependencies.

  • Pull request title:

    [dev-v2.X] <chart> <version> <action>
    
    • <action>: 1 of (bump; remove; UnRC)

Checkpoints for Chart Bumps

release.yaml:

  • Each chart version in release.yaml DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.
  • Each chart version in release.yaml IS exactly 1 more patch or minor version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.

Chart.yaml and index.yaml:

  • The index.yaml file has an entry for your new chart version.
  • The index.yaml entries for each chart matches the Chart.yaml for each chart.
  • Each chart has ALL required annotations
    • kube-version annotation
    • rancher-version annotation
    • permits-os annotation (indicates Windows and/or Linux)

Fill the following only if required by your manager.

Issue: harvester/harvester#7501
Solution
QA Testing Considerations

@Vicente-Cheng Vicente-Cheng requested a review from a team as a code owner February 4, 2025 14:56
Copy link

github-actions bot commented Feb 4, 2025

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@Vicente-Cheng
Copy link
Contributor Author

Hi @nicholasSUSE,
Did you know about the create-app-token error like below (when running validating):

Run actions/create-github-app-token@v1
Run '/home/runner/k8s/index.js'
/__w/_actions/actions/create-github-app-token/v1/dist/main.cjs:[4](https://github.com/rancher/charts/actions/runs/13138264668/job/36694554475?pr=5086#step:5:5)2278
  throw new Error("Input required and not supplied: app-id");
  ^

Error: Input required and not supplied: app-id
    at Object.<anonymous> (/__w/_actions/actions/create-github-app-token/v1/dist/main.cjs:42278:9)
    at Module._compile (node:internal/modules/cjs/loader:14[6](https://github.com/rancher/charts/actions/runs/13138264668/job/36694554475?pr=5086#step:5:8)9:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:1[7](https://github.com/rancher/charts/actions/runs/13138264668/job/36694554475?pr=5086#step:5:9)4:12)
    at node:internal/main/run_main_module:28:49

Node.js v20.1[8](https://github.com/rancher/charts/actions/runs/13138264668/job/36694554475?pr=5086#step:5:10).0
Error: Error: failed to run script step: command terminated with non-zero exit code: error executing command [sh -e /__w/_temp/eea3cfd0-e370-11ef-875[9](https://github.com/rancher/charts/actions/runs/13138264668/job/36694554475?pr=5086#step:5:11)-47488719e94c.sh], exit code 1
Error: Process completed with exit code 1.
Error: Executing the custom container implementation failed. Please contact your self hosted runner administrator.

I can pass the make validate on my local, but I'm not sure why always fail in this stage.
Thanks!

Signed-off-by: Vicente Cheng <[email protected]>
@Vicente-Cheng Vicente-Cheng force-pushed the bump-harvester-csi-driver-v0.1.23-v2.8 branch from f397938 to c3f58ce Compare February 7, 2025 01:55
Copy link

github-actions bot commented Feb 7, 2025

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@FrankYang0529 FrankYang0529 merged commit 1247133 into rancher:dev-v2.8 Feb 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants