Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Network Configurators #363

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

anmazzotti
Copy link
Contributor

Documentation for rancher/elemental-operator#819

Signed-off-by: Andrea Mazzotti <[email protected]>
@anmazzotti anmazzotti requested a review from a team as a code owner August 9, 2024 12:36
@anmazzotti anmazzotti self-assigned this Aug 9, 2024
Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for elemental-docs-staging ready!

Name Link
🔨 Latest commit 9536684
🔍 Latest deploy log https://app.netlify.com/sites/elemental-docs-staging/deploys/66bb7aae1a7aed0008b5e461
😎 Deploy Preview https://deploy-preview-363--elemental-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Andrea Mazzotti <[email protected]>
@anmazzotti anmazzotti changed the title Document nm-configurator Document Network Configurators Aug 13, 2024
@anmazzotti
Copy link
Contributor Author

anmazzotti commented Aug 13, 2024

@fgiudici I initially went with 3 subpages for nmc, nmstate, and nmconnections, but I ended up adding the three options with a sample config for each as a 3 different tabs in the networking page.

Makes me feel the networking page is quite vast, but I find it still manageable. If you think otherwise let me know and I can split it in subpages.

@fgiudici
Copy link
Member

@fgiudici I initially went with 3 subpages for nmc, nmstate, and nmconnections, but I ended up adding the three options with a sample config for each as a 3 different tabs in the networking page.

Makes me feel the networking page is quite vast, but I find it still manageable. If you think otherwise let me know and I can split it in subpages.

I like more the tabs 👍🏼

Signed-off-by: Andrea Mazzotti <[email protected]>
Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of examples, which I think the users will like a lot, well done!
We present all together (declarative networking + IPAM + examples) which while it is how it is implemented and how should be used, it could be harder to follow for a user not used to IPAM and declarative networking.
May be more easy to follow if we introduce first declarative networking (without IPAM), present the generators and after that we cover IPAM.
Ideally main page would be an overview of all the pieces and different subpages would cover the details for declarative network and for IPAM. Moreover, subpages with nothing more than ready to use network configuration examples would be handy, covering also complex network configurations (e.g., teams, bonds, bridges, vlans, ...).
So, guess we need a new EPIC to track the documentation effort of the declarative networking 😆

Regarding this PR, it is a pretty nice initial coverage of the feature, please merge it asap! 🚀 🎉

Signed-off-by: Andrea Mazzotti <[email protected]>
@anmazzotti anmazzotti merged commit 3f7c7f8 into rancher:main Aug 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants