Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing questions.yaml file #567

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Add missing questions.yaml file #567

merged 1 commit into from
Nov 21, 2023

Conversation

juadk
Copy link
Contributor

@juadk juadk commented Nov 21, 2023

To test the dev chart installation in the marketplace, we need to add the questions.yaml and app-readme file from https://github.com/rancher/charts/tree/dev-v2.8/charts/elemental/103.0.0%2Bup1.3.4

Signed-off-by: Julien Adamek <[email protected]>
@juadk juadk requested a review from a team as a code owner November 21, 2023 14:03
@juadk juadk added the area/chart Chart related changes label Nov 21, 2023
@juadk juadk self-assigned this Nov 21, 2023
Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good here! Thanks!

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8cf8b03) 54.17% compared to head (93e6b01) 54.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #567   +/-   ##
=======================================
  Coverage   54.17%   54.17%           
=======================================
  Files          39       39           
  Lines        6005     6005           
=======================================
  Hits         3253     3253           
  Misses       2470     2470           
  Partials      282      282           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juadk juadk merged commit cbe7427 into main Nov 21, 2023
12 of 13 checks passed
@juadk juadk deleted the add_question_yaml_file branch November 21, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chart Chart related changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants