Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grub package to seedimage built in OBS #568

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Nov 23, 2023

Getting the following error when building a raw disk image using a seedimage-builder from dev:

DEBU[2023-11-23T14:06:30Z] Running cmd: 'grub2-editenv /iso/build/oem/grubenv set next_entry=recovery'
ERRO[2023-11-23T14:06:30Z] Error running command: exec: "grub2-editenv": executable file not found in $PATH
ERRO[2023-11-23T14:06:30Z] Failed setting grub variables:
ERRO[2023-11-23T14:06:30Z] failed setting firstboot menu entry: exec: "grub2-editenv": executable file not found in $PATH
ERRO[2023-11-23T14:06:30Z] Woophs, something went terribly wrong: 1 error occurred:
        * exec: "grub2-editenv": executable file not found in $PATH

@frelon frelon requested a review from a team as a code owner November 23, 2023 14:12
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20ce1e0) 54.13% compared to head (fb14982) 54.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #568   +/-   ##
=======================================
  Coverage   54.13%   54.13%           
=======================================
  Files          39       39           
  Lines        6005     6005           
=======================================
  Hits         3251     3251           
  Misses       2472     2472           
  Partials      282      282           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frelon frelon enabled auto-merge (squash) November 23, 2023 14:26
@frelon frelon force-pushed the seedimage-add-grub branch from ace7ebe to fb14982 Compare November 24, 2023 12:33
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frelon frelon merged commit f1d44d8 into rancher:main Nov 24, 2023
@frelon frelon deleted the seedimage-add-grub branch November 24, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants