Label Templates: rework collection of 'System Data' info #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow automatic conversion of data to map[string]interface{} (Template
Labels format) using reflection.
Add support to old variable names (to be deprecated sooner or later)
and add SMBIOS data collection from hostinfo package: this should allow
to drop dmidecode tool requirement for SMBIOS data retrieval.
also changed the 'raw' option to 'full' one, to allow dumping all the available information using the same reflection based translation as (partially) done with the regular collected Label Templates.
the hostinfo package is now able to collect all the data, also the SMBIOS one: drop the dmidecode package. Signed-off-by: Francesco Giudici <[email protected]>
github-actions
bot
added
area/operator
anmazzotti
approved these changes
Sep 9, 2024
cmd/register/showdata.go
Outdated
|
|
||
| cmd.Flags().BoolVarP(&full, "full", "f", false, "dump full, raw data before postprocessing to refine available label templates variables") | ||
| _ = viper.BindPFlag("full", cmd.Flags().Lookup("full")) | ||
| cmd.Flags().StringVarP(&output, "output", "o", "json", "output format ['"+OUTYAML+"', '"+OUTJSON+"', '"+OUTJSONCOMPACT+"']") |
There was a problem hiding this comment.
Nitpick: could just be --format instead of --output.
Signed-off-by: Francesco Giudici <[email protected]>
output --> format full --> raw Signed-off-by: Francesco Giudici <[email protected]>
Signed-off-by: Francesco Giudici <[email protected]>
|
Closing in favor of #843 : reviewed the variable names and kept the old smbios and hardware legacy labels for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow automatic conversion of data to map[string]interface{} (Label Templates format) using reflection.
Add support to "old" variable names (that we may want to deprecate sooner or later, in the meanwhile we can just document the new syntax only) and add SMBIOS data collection from hostinfo package.
Drop dmidecode package as we SMBIOS data retrieval is now performed by the hostinfo package.
No more requirement on the dmidecode tool.
Fixes #834