-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve GHA tests steps #51
Conversation
Signed-off-by: Chandan Pinjani <[email protected]>
Signed-off-by: Chandan Pinjani <[email protected]>
Signed-off-by: Chandan Pinjani <[email protected]>
Signed-off-by: Chandan Pinjani <[email protected]>
@@ -172,23 +173,23 @@ jobs: | |||
make e2e-provisioning-tests | |||
|
|||
- name: Importing cluster tests | |||
if: ${{ inputs.run_p0_importing_tests == true }} | |||
if: ${{ !cancelled() && inputs.run_p0_importing_tests == true }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! It works perfectly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you are at this, can you make 2 small changes to the Makefile to allow testing rancher images like 2.7.1-head?
I ran into an error here.
helm install rancher --devel rancher-latest/rancher --version 2.7.11-head \
--namespace cattle-system \
--create-namespace \
--set global.cattle.psp.enabled=false \
--set hostname=34.131.38.16.sslip.io \
--set bootstrapPassword=*** \
--set replicas=1 \
--set rancherImageTag=v2.7.11-head \
--wait
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /etc/rancher/k3s/k3s.yaml
WARNING: Kubernetes configuration file is world-readable. This is insecure. Location: /etc/rancher/k3s/k3s.yaml
Error: INSTALLATION FAILED: chart "rancher" matching 2.7.11-head not found in rancher-latest index. (try 'helm repo update'): no chart version found for rancher-2.7.11-head
make: *** [Makefile:31: install-rancher] Error 1
Fixing the Makefile to remove --version
flag from the helm command, seems to fix the issue. I tested it with multiple versions and image tag and it worked as expected.
See: 6b21b34
Signed-off-by: Chandan Pinjani <[email protected]>
What does this PR do?
This implements to run tests independent of each other
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #16
Checklist:
https://github.com/rancher/hosted-providers-e2e/actions/runs/7797757146