Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GKE tests when upgrading a major version and add custom workflow run-name to all the workflows #53

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

valaparthvi
Copy link
Collaborator

@valaparthvi valaparthvi commented Feb 8, 2024

What does this PR do?

  1. Fix GKE tests that failed when upgrading from one major version to another, for e.g v1.26.8-gke.200 -> v1.27.3-gke.100. Ref: GKE-E2E
time="2024-02-07T09:58:19Z" level=info msg="ClusterID: c-dwrfx, Message: [googleapi: Error 400: Node version \"1.27.3-gke.100\" must not have a greater minor version than master version \"1.26.8-gke.200\".\nDetails:\n[\n  ***\n    \"@type\": \"type.googleapis.com/google.rpc.RequestInfo\",\n    \"requestId\": \"0xe424a128d6e3269e\"\n  ***\n]\n, badRequest], Error: true, State: updating, Transitioning: false"
  1. Add custom workflow run-name to all the workflows to easily identify which downstream, rancher and upstream versions were using for a specific run instead of looking into inputs.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #

Checklist:

Special notes for your reviewer:

@valaparthvi valaparthvi requested a review from cpinjani February 8, 2024 11:30
@valaparthvi valaparthvi merged commit 036db7f into main Feb 8, 2024
4 of 8 checks passed
@valaparthvi valaparthvi deleted the fix-gke branch February 8, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants