-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to run tests on available Rancher Manager #65
Conversation
Signed-off-by: Chandan Pinjani <[email protected]>
Signed-off-by: Chandan Pinjani <[email protected]>
.github/workflows/aks.yaml
Outdated
@@ -12,11 +11,6 @@ on: | |||
required: true | |||
type: string | |||
default: 2.8-head | |||
k3s_version: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I like this change. I have been frequently using this input and I find it helpful.
This 10 input limit is always going to be blocker. I see it being one when we add more test suites and need a way to run the tests. Maybe we can use choice
input type, anyway that's a future problem.
For now, can you do something like <downstream_version/rancher_version/k3s_version>
the same way you did for <hostname/password>? The 3 of them are almost always used together and we can also get rid of 2 extra inputs without compromising.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll refactor the inputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one more change that we can introduce in this PR to reduce the input number.
See:
This way when we add a new test suite, it will just be another addition to the JSON.
Ref:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a0e19a2
to
9cdee16
Compare
Signed-off-by: Chandan Pinjani <[email protected]>
What does this PR do?
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #62
Checklist:
Custom Rancher:
AKS-E2E EKS-E2E GKE-E2E
CI Installed Rancher:
AKS-E2E EKS-E2E GKE-E2E
Special notes for your reviewer:
Since GHA has limitation of max 10 inputs for workflow_dispatch, disabled k3s_version input as a tradeoff and uyse default k3s version. https://github.com/rancher/hosted-providers-e2e/actions/runs/7884132500