Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to run tests on available Rancher Manager #65

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Conversation

cpinjani
Copy link
Collaborator

@cpinjani cpinjani commented Feb 13, 2024

What does this PR do?

  • Adds support in framework to run tests on any available Rancher manager
  • Changed job summary, as custom run-name was not working on scheduled jobs

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #62

Checklist:

  • Squashed commits into logical changes
  • GitHub Actions

Custom Rancher:
AKS-E2E EKS-E2E GKE-E2E

CI Installed Rancher:
AKS-E2E EKS-E2E GKE-E2E

Special notes for your reviewer:

Since GHA has limitation of max 10 inputs for workflow_dispatch, disabled k3s_version input as a tradeoff and uyse default k3s version. https://github.com/rancher/hosted-providers-e2e/actions/runs/7884132500

@cpinjani cpinjani added the enhancement New feature or request label Feb 13, 2024
@cpinjani cpinjani requested a review from valaparthvi February 13, 2024 14:51
@cpinjani cpinjani self-assigned this Feb 13, 2024
@cpinjani cpinjani changed the title Add ability to run tests on non-CI installed Rancher Manager Add ability to run tests on available Rancher Manager Feb 13, 2024
Signed-off-by: Chandan Pinjani <[email protected]>
Signed-off-by: Chandan Pinjani <[email protected]>
@@ -12,11 +11,6 @@ on:
required: true
type: string
default: 2.8-head
k3s_version:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I like this change. I have been frequently using this input and I find it helpful.

This 10 input limit is always going to be blocker. I see it being one when we add more test suites and need a way to run the tests. Maybe we can use choice input type, anyway that's a future problem.

For now, can you do something like <downstream_version/rancher_version/k3s_version> the same way you did for <hostname/password>? The 3 of them are almost always used together and we can also get rid of 2 extra inputs without compromising.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll refactor the inputs

Copy link
Collaborator

@valaparthvi valaparthvi Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one more change that we can introduce in this PR to reduce the input number.
See:

  1. 9a917d9
  2. GKE 1.27.3-gke.100 on Rancher v2.8-head deployed on v1.27.9+k3s1

This way when we add a new test suite, it will just be another addition to the JSON.

Ref:

  1. https://github.com/orgs/community/discussions/8774#discussioncomment-3747116
  2. https://docs.github.com/en/actions/learn-github-actions/expressions#fromjson

Copy link
Collaborator Author

@cpinjani cpinjani Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Job runs after refactoring (9cdee16). Ran with different combinations of tests and they got executed as per the user input.
Custom Rancher:
AKS-E2E EKS-E2E GKE-E2E

CI Installed Rancher:
AKS-E2E EKS-E2E GKE-E2E

@valaparthvi valaparthvi added the github_actions Pull requests that update GitHub Actions code label Feb 15, 2024
@cpinjani cpinjani force-pushed the byor branch 8 times, most recently from a0e19a2 to 9cdee16 Compare February 16, 2024 06:17
Signed-off-by: Chandan Pinjani <[email protected]>
@cpinjani cpinjani merged commit c600acf into main Feb 16, 2024
4 of 5 checks passed
@cpinjani cpinjani deleted the byor branch February 16, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bring your own Rancher
2 participants