Update prometheus federator app version to 0.3.5 / charts to 0.4.1 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update chart version to 0.4.1 pin upstream rancher-monitoring dep to 103.0.2-up45.31.1 Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
joshmeranda
reviewed
Dec 14, 2023
| @@ -58,7 +58,7 @@ helmProjectOperator: | |||
|
|
|||
| image: | |||
| repository: rancher/prometheus-federator | |||
| tag: v0.3.4 | |||
| tag: v0.3.5 | |||
There was a problem hiding this comment.
I don't think this tag exists? (same issue as above)
There was a problem hiding this comment.
In the docs it mentions adding the git tag after a PR is merged, which didn't seem right but looking at how the automation works it seems that its fine
There was a problem hiding this comment.
Taking a look at past PRs, we are expected to tag the merge commit as the release version, CI runs with the a local $TAG option
joshmeranda
reviewed
Dec 14, 2023
joshmeranda
requested changes
Dec 14, 2023
bump e2e ci go version to 1.20 Signed-off-by: Alexandre Lamarre <[email protected]> enable shell tracing in e2e ci Signed-off-by: Alexandre Lamarre <[email protected]> debug versions in install rancher monitoring e2e ci Signed-off-by: Alexandre Lamarre <[email protected]> set helm version to v.3.13.1 in e2e ci Signed-off-by: Alexandre Lamarre <[email protected]>
alexandreLamarre
force-pushed
the
update-federator
branch
from
93d5fe0 to
cff814f
Compare
joshmeranda
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
Checklist
Please fill out this table to identify which fields need to be modified in your PR.
Under
Status, either indicateDoes Not ApplyorAdded to this PR.versionin rancher-project-monitoringpackage.yamlrancher-project-monitoringchart to make changeshelmProjectOperator.image.tagin prometheus-federatorvalues.yamlmain.gofileappVersionin prometheus-federatorChart.yamlhelmProjectOperator.image.tagin the above boxversionin prometheus-federatorChart.yamlappVersionin the above box or you modified the contents of theprometheus-federatorchart to make changes