[main] helm-project-operator and helm-locker repo reorg updates #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallardduck
force-pushed
the
dpock/repo-updates
branch
2 times, most recently
from
d408ff6 to
8210a5c
Compare
|
So I just realized that updating the chart in this PR is a chicken and egg problem. We want to update the chart dependencies to make sure it uses the new That said, I don't think anything in our CI/tests will use the new image tag for testing, since it should use "local" (to the test runner) builds of the images for testing. In these cases the tag in the Do take note that the current E2E test failures stem from a mixture of issue. Mainly:
|
mallardduck
force-pushed
the
dpock/repo-updates
branch
2 times, most recently
from
52d700f to
1944bbb
Compare
This was referenced Oct 8, 2024
joshmeranda
reviewed
Oct 8, 2024
assets/prometheus-federator/prometheus-federator-0.4.3-rc.1.tgz
Outdated
Show resolved
Hide resolved
joshmeranda
requested changes
Oct 8, 2024
...if this were ever false then the chart does nothing.
mallardduck
force-pushed
the
dpock/repo-updates
branch
from
e2c751a to
48f69c0
Compare
joshmeranda
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Produced a
mallardduck/prometheus-federator:reorg-demoimage and pushed to dockerhub.(This PR is based on a local repo branch equal to: #93)