Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vai: do not discard closing statement errors #462

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

moio
Copy link
Contributor

@moio moio commented Jan 24, 2025

Errors in deferred CloseStmt calls are currently ignored.

This patch captures such errors and returns them (possibly joined with another error if it happened).

Part of rancher/rancher#47825

@moio moio requested a review from ericpromislow January 24, 2025 13:18
ericpromislow
ericpromislow previously approved these changes Jan 27, 2025
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward

@moio moio force-pushed the vai_handle_all_errors branch from a9700c5 to 8b10423 Compare February 6, 2025 09:19
@moio
Copy link
Contributor Author

moio commented Feb 6, 2025

Rebased on top of current main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants