Skip to content

[release-v2.11] Move helm charts from rancher/charts to /charts dir #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: rancher-charts-release/v2.11
Choose a base branch
from

Conversation

pratikjagrut
Copy link

PR Description

We're integrating the Auto Chart Bumps feature into the System Upgrade Controller (SUC) repository to streamline chart maintenance and align with Rancher's release structure.

Why This Change?

  • Currently, the SUC chart resides in rancher/charts, but due to strict requirements, we need a separate repo for managing SUC chart.
  • One key requirement is maintaining three active release branches for Rancher, which makes it difficult to continue hosting the chart in the rancher/charts repository.
  • Instead of creating a new repository, we've decided to host the SUC chart in a dedicated branch within the existing SUC repo.
  • We'll use the same branch for all three active releases instead of three branches.

What’s Changing?

  • A new branch, rancher-charts-release/v2.11, will be used exclusively for SUC charts.
  • All new PRs for the Rancher SUC chart will be created in this branch instead of rancher/charts.
  • This branch will only contain the SUC chart files, not the SUC source code.
  • The auto chart bump mechanism will automatically watch this branch and update charts.

Related issue: #49087.

Copy link
Collaborator

@snasovich snasovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is now https://github.com/rancher/charts/tree/dev-v2.11/charts/system-upgrade-controller/106.0.0 for v2.11.0 so we should use it as the base.

@pratikjagrut pratikjagrut force-pushed the rancher-charts-release-automation-v2.11 branch from f73ad1e to ba56dd9 Compare March 19, 2025 20:04
@pratikjagrut
Copy link
Author

There is now https://github.com/rancher/charts/tree/dev-v2.11/charts/system-upgrade-controller/106.0.0 for v2.11.0 so we should use it as the base.

@snasovich Done.

@brandond brandond changed the title Move helm charts from rancher/charts to /charts dir [release-v2.11] Move helm charts from rancher/charts to /charts dir Mar 19, 2025
@jiaqiluo jiaqiluo requested a review from snasovich April 3, 2025 22:07
Copy link
Member

@jiaqiluo jiaqiluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, they are identical to the chart at https://github.com/rancher/charts/tree/dev-v2.11/charts/system-upgrade-controller/106.0.0

Hi @pratikjagrut, is it true that, instead of maintaining the (most-of-the-time-idential) templates in multiple branches in the rancher/charts repo, we will maintain them in multiple branches here? So, if we need to add a change to the chart and release a new version of the chart in both Rancher 2.10 and 2.11 release lines, we will need to raise 2 PRs in this repo to the corresponding branches, is it right?

@pratikjagrut
Copy link
Author

@jiaqiluo Yes, that is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants