Skip to content

Commit 8254e3a

Browse files
committed
repair ancient and incorrect comment
it referred towards _columntoproperty refering to lists of MapperProperty. this comment goes all the way to pre 0.1 being released. it's likely been wrong for nearly all that time. Change-Id: I71234ae58a6253249d92224356e38372e4aff148
1 parent 11bf824 commit 8254e3a

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

lib/sqlalchemy/orm/mapper.py

+3-7
Original file line numberDiff line numberDiff line change
@@ -1407,19 +1407,14 @@ def _configure_pks(self):
14071407
)
14081408

14091409
def _configure_properties(self):
1410-
# Column and other ClauseElement objects which are mapped
14111410

1412-
# TODO: technically this should be a DedupeColumnCollection
1413-
# however DCC needs changes and more tests to fully cover
1414-
# storing columns under a separate key name
1411+
# TODO: consider using DedupeColumnCollection
14151412
self.columns = self.c = sql_base.ColumnCollection()
14161413

14171414
# object attribute names mapped to MapperProperty objects
14181415
self._props = util.OrderedDict()
14191416

1420-
# table columns mapped to lists of MapperProperty objects
1421-
# using a list allows a single column to be defined as
1422-
# populating multiple object attributes
1417+
# table columns mapped to MapperProperty
14231418
self._columntoproperty = _ColumnMapping(self)
14241419

14251420
# load custom properties
@@ -3609,6 +3604,7 @@ class _ColumnMapping(dict):
36093604
__slots__ = ("mapper",)
36103605

36113606
def __init__(self, mapper):
3607+
# TODO: weakref would be a good idea here
36123608
self.mapper = mapper
36133609

36143610
def __missing__(self, column):

0 commit comments

Comments
 (0)