Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CA and ADCS Template metadata to Pkcs12 #182

Closed
wants to merge 1 commit into from

Conversation

cdelafuente-r7
Copy link
Contributor

This adds the following metadata to Pkcs12:

  • CA: the certificate authority that issued the certificate.
  • ADCS Template: the AD CS certificate template used to issue the certificate.

The data is now serialized in the Pkcs12's data field with the following format: msf_pkcs12:<base64 cert>:<ca>:<ADCS template>.

@adfoster-r7
Copy link
Contributor

Thanks! I'll just swap this PR into draft mode until we've wired up the corresponding UI changes in Pro to support consuming this metadata

I'm thinking this particular approach would require additional migration logic to support going from the old format to the new format, otherwise folk that have existing pkcs12 certs in their database might run into problems - but we can cross that bridge once things are wired up into Pro

@adfoster-r7 adfoster-r7 marked this pull request as draft December 16, 2024 12:08
@cdelafuente-r7
Copy link
Contributor Author

Yes, absolutely, I agree. Additional migration logic will be a good idea.

@cdelafuente-r7
Copy link
Contributor Author

Closing this PR since the head branch is on rapid7 repo. I'll open a new PR with the correct head branch.

@cdelafuente-r7 cdelafuente-r7 deleted the enh/MS-9710/add_pkcs12_metadata branch December 16, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants