Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off package proxy cache on conda-based jobs #282

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Feb 14, 2025

This was originally opened for testing: https://github.com/rapidsai/rapids-multi-gpu/pull/72#issuecomment-2660149987

But then expanded to turn off the proxy cache for all conda-based jobs that run on self-hosted runners, for issues like this:

rapidsai/kvikio#603 (comment)

@jameslamb jameslamb changed the title WIP: [NEVER MERGE} turn off package proxy cache on conda-python-tests jobs WIP: [NEVER MERGE] turn off package proxy cache on conda-python-tests jobs Feb 14, 2025
@jameslamb
Copy link
Member Author

This branch shouldn't be deleted until this is merged: https://github.com/rapidsai/rapids-multi-gpu/pull/76

@bdice
Copy link
Contributor

bdice commented Feb 21, 2025

We might need to turn off the cache for conda C++ test jobs too. We are seeing problems in cuDF C++ tests, which can't find the latest nvcomp packages.

https://github.com/nv-gha-runners/roadmap/issues/192
https://github.com/rapidsai/cudf/actions/runs/13460614745/job/37616774217?pr=17944#step:9:79

@jameslamb
Copy link
Member Author

We might need to turn off the cache for conda C++ test jobs too

Sure. This PR was only opened for testing https://github.com/rapidsai/rapids-multi-gpu/pull/72, which is now closed. And rapids-multi-gpu is no longer relying on it, as of https://github.com/rapidsai/rapids-multi-gpu/pull/76.

If we want to re-purpose this branch to actually change where the proxy cache is used in RAPIDS, that's fine.

@jameslamb jameslamb changed the title WIP: [NEVER MERGE] turn off package proxy cache on conda-python-tests jobs turn off package proxy cache on conda-based jobs Feb 21, 2025
@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change and removed DO NOT MERGE labels Feb 21, 2025
@jameslamb jameslamb requested a review from bdice February 21, 2025 23:52
@jameslamb jameslamb marked this pull request as ready for review February 21, 2025 23:52
@jameslamb jameslamb requested a review from a team as a code owner February 21, 2025 23:52
@bdice bdice merged commit 3fd3c36 into branch-25.04 Feb 21, 2025
1 check passed
@ajschmidt8 ajschmidt8 deleted the no-proxy-cache branch February 24, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants