Skip to content

#622 i2c altimeter issue fix #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

badMOS-BITSian
Copy link

#622 fixed the issue by implementing two functions - mpl3115a2_set_sealevel_pressure() and mpl3115a2_get_sealevel_pressure(). Added prototype in mpl3115a2_i2c.h file and updated CMakeLists.txt.

Copy link
Contributor

@peterharperuk peterharperuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A couple of minor comments, but looks good.

@badMOS-BITSian
Copy link
Author

Can we get this merged @peterharperuk ??

@peterharperuk
Copy link
Contributor

peterharperuk commented Apr 10, 2025

Seems to work well after setting the sea level pressure. I think we should remove the unhelpful and alarming "FIFO overflow!" message.
Might be useful to make it configurable for barometer mode - but that could be done later.

@peterharperuk peterharperuk added this to the 2.1.2 milestone Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants