Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible segfault in UF2 save #205

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Fix possible segfault in UF2 save #205

merged 1 commit into from
Feb 20, 2025

Conversation

will-v-pi
Copy link
Contributor

When saving a binary to a UF2 which is not a multiple of PAGE_SIZE, this memset can cause a segfault on the final block, as it writes past the end of block.data. This fixes that issue.

@will-v-pi will-v-pi added this to the 2.1.2 milestone Feb 20, 2025
@will-v-pi will-v-pi requested a review from kilograham February 20, 2025 14:26
@kilograham kilograham merged commit 3953ccc into develop Feb 20, 2025
35 checks passed
@kilograham kilograham deleted the uf2-save-segfault branch February 20, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilograham kilograham kilograham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@will-v-pi @kilograham