Skip to content

pieeprom-2025-02-11: 2712: CM5 no-wifi stability improvements (latest) #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

timg236
Copy link
Collaborator

@timg236 timg236 commented Feb 11, 2025

  • recovery: Walk partitions to delete recovery.bin
    Previously, recovery.bin would fail to delete itself if the bootrom loaded recovery.bin where there are multiple FAT partitions and the first partition does not contain recovery.bin Update the rename code to walk the partition table to find the recovery.bin file to delete.
  • pi5: Add config filter for simple boot variable expressions (experimental)
    Add support for a new bootloader/config.txt conditional filter which tests the partition, boot_count and boot_arg1 variables. Syntax (no spaces): ARG boot_arg1, boot_count or partition (EEPROM config stage only)
    [ARG=VALUE] selected if (ARG == VALUE)
    [ARG&MASK] selected if ((ARG & VALUE) != 0))
    [ARG&MASK=VALUE] selected if ((ARG & MASK) == VALUE)
    [ARG<VALUE] selected if (ARG < VALUE)
    [ARG>VALUE] selected if (ARG > VALUE)
    where VALUE and MASK are unsigned integer constants and ARG
    corresponds to the value in the reset register before the
    config file is parsed.
  • pi5: Add a boot-count bootloader variable (experimental)
    Store the boot-count in a reset register and increment just
    before the boot-order state-machine. The boot-count variable
    is visible via device-tree /proc/device-tree/chosen/bootloader/count
    and can be read/set via vcmailbox
    GET: sudo vcmailbox 0x0003008d 4 4 0
    SET to N: sudo vcmailbox 0x0003808d 4 4 N
  • pi5: Add user-defined reboot argument (boot_arg1) (experimental)
    Add support for a user-defined boot parameter stored in a reset-safe
    scratch register on BCM2712. This is visible via device-tree at
    /proc/device-tree/chosen/bootloader/arg1 and via vcmailboxes
    GET arg1: sudo vcmailbox 0x0003008c 8 8 1 0
    SET arg1 to 42: sudo vcmailbox 0x0003808c 8 8 1 42
    or via config.txt
    set_reboot_arg1=42
    The variable is NOT cleared automatically and will persist until
    a power-on-reset.
  • Enable overriding of high partition numbers
    Previously, the PARTITION=N bootloader config setting would only
    be used at power on reset or if the partition number passed to
    reboot was zero.
    Change the behaviour so that the bootloader config PARTITION
    property can override the reboot partition number if the reboot
    parameter is > 31.
  • Disable WiFi PMIC output on CM5 modules without WiFi
    Disable the 3.7V WiFi power supply on CM5 modules which do not have a
    WiFi module fitted. This fixes some stability issues where a CM5
    would shutdown due to a spurious over-voltage condition on the
    non-connected WiFi power supply.
  • Add memory barrier to the mbox handler
    Firmware issue 1944 reports receiving kernel warnings about firmware
    requests where the status return code is 0. This should not be
    possible, as handle_mbox_property always sets the top bit of the return
    code, with the bottom bit indicating success or failure. If the firmware
    had died, the firmware driver would report a timeout due to the lack of
    a mailbox interrupt, and that isn't happening.
    See: raspberrypi-firmware soc:firmware: Request 0x00030002 returned status 0x00000000 firmware#1944
  • support dts files with size-cells of 2
    DTS files with a top-level #size-cells of 2 make a lot of sense for
    systems with a lot of RAM, but the firmware is currently inconsistent
    in its support for that. Fix up the other cases to honor #size-cells
    and #address-cells.
  • Disable SDIO2 for CM5s without WiFi
    It has been observed that CM5s without WiFi hang on reboot. To prevent
    that, disable the sdio2 node on those devices.
    See: CM5 without wifi hangs on reboot linux#6647
  • arm_dt: Use dtoverlay_enable_node
    Convert the open-coded DT node status changes to use the new dtoverlay
    method dtoverlay_enable_node.
  • dtoverlay: Add dtoverlay_enable_node
    Add a helper function for setting the status of a node.

* recovery: Walk partitions to delete recovery.bin
  Previously, recovery.bin would fail to delete itself
  if the bootrom loaded recovery.bin where there are multiple FAT
  partitions and the first partition does not contain recovery.bin
  Update the rename code to walk the partition table to find
  the recovery.bin file to delete.
* pi5: Add config filter for simple boot variable expressions (experimental)
  Add support for a new bootloader/config.txt conditional filter
  which tests the partition, boot_count and boot_arg1 variables.
  Syntax (no spaces):
  ARG boot_arg1, boot_count or partition (EEPROM config stage only)
  [ARG=VALUE]      selected if (ARG == VALUE)
  [ARG&MASK]       selected if ((ARG & VALUE) != 0))
  [ARG&MASK=VALUE] selected if ((ARG & MASK) == VALUE)
  [ARG<VALUE]      selected if (ARG < VALUE)
  [ARG>VALUE]      selected if (ARG > VALUE)
  where VALUE and MASK are unsigned integer constants and ARG
  corresponds to the value in the reset register before the
  config file is parsed.
* pi5: Add a boot-count bootloader variable (experimental)
  Store the boot-count in a reset register and increment just
  before the boot-order state-machine. The boot-count variable
  is visible via device-tree /proc/device-tree/chosen/bootloader/count
  and can be read/set via vcmailbox
  GET: sudo vcmailbox 0x0003008d 4 4 0
  SET to N: sudo vcmailbox 0x0003808d 4 4 N
* pi5: Add user-defined reboot argument (boot_arg1) (experimental)
  Add support for a user-defined boot parameter stored in a reset-safe
  scratch register on BCM2712.  This is visible via device-tree at
  /proc/device-tree/chosen/bootloader/arg1 and via vcmailboxes
  GET arg1: sudo vcmailbox 0x0003008c 8 8 1 0
  SET arg1 to 42: sudo vcmailbox 0x0003808c 8 8 1 42
  or via config.txt
  set_reboot_arg1=42
  The variable is NOT cleared automatically and will persist until
  a power-on-reset.
* Enable overriding of high partition numbers
  Previously, the PARTITION=N bootloader config setting would only
  be used at power on reset or if the partition number passed to
  reboot was zero.
  Change the behaviour so that the bootloader config PARTITION
  property can override the reboot partition number if the reboot
  parameter is > 31.
* Disable WiFi PMIC output on CM5 modules without WiFi
  Disable the 3.7V WiFi power supply on CM5 modules which do not have a
  WiFi module fitted. This fixes some stability issues where a CM5
  would shutdown due to a spurious over-voltage condition on the
  non-connected WiFi power supply.
* Add memory barrier to the mbox handler
  Firmware issue 1944 reports receiving kernel warnings about firmware
  requests where the status return code is 0. This should not be
  possible, as handle_mbox_property always sets the top bit of the return
  code, with the bottom bit indicating success or failure. If the firmware
  had died, the firmware driver would report a timeout due to the lack of
  a mailbox interrupt, and that isn't happening.
  See: raspberrypi/firmware#1944
* support dts files with size-cells of 2
  DTS files with a top-level #size-cells of 2 make a lot of sense for
  systems with a lot of RAM, but the firmware is currently inconsistent
  in its support for that. Fix up the other cases to honor #size-cells
  and #address-cells.
* Disable SDIO2 for CM5s without WiFi
  It has been observed that CM5s without WiFi hang on reboot. To prevent
  that, disable the sdio2 node on those devices.
  See: raspberrypi/linux#6647
* arm_dt: Use dtoverlay_enable_node
  Convert the open-coded DT node status changes to use the new dtoverlay
  method dtoverlay_enable_node.
* dtoverlay: Add dtoverlay_enable_node
  Add a helper function for setting the status of a node.
@timg236 timg236 merged commit 34eab17 into raspberrypi:master Feb 11, 2025
@timg236 timg236 deleted the pieeprom-2025-02-11-2712 branch February 11, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant