Skip to content
This repository was archived by the owner on Dec 10, 2019. It is now read-only.

Conversation

@hectcastro
Copy link
Contributor

@hectcastro hectcastro commented May 2, 2017

Split the Raster Foundry Python client out from the main repository and do any work necessary to support cutting a release:

  • Rename to rasterfoundry
  • Add more layers of release testing to tox
  • Add Travis CI support
  • Add license
  • Update README

Fixes raster-foundry/raster-foundry#1598.


Testing

Inspect the diff and ensure the Travis build succeeds.

Split the Raster Foundry Python client out from the main repository and do any
work necessary to support cutting a release:

- Rename to `rasterfoundry`
- Add more layers of release testing to `tox`
- Add Travis CI support
- Add license
- Update README
@hectcastro hectcastro requested a review from notthatbreezy May 2, 2017 21:49
Copy link

@notthatbreezy notthatbreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- the only thing I'm hesitant about is how we're going to manage keeping this spec.yml in sync with the spec in the main repository. That's more of a process problem than code though so I think it's something we'll just have to be aware of.

@hectcastro
Copy link
Contributor Author

Yeah. At a high level, I figured that we'd encode the process of getting the latest spec in update (not added yet).

Some questions that come out of that for me:

  • Do we always just pull the latest spec and expect development to happen based on that?
  • Do we do something in the spec publishing process to version it so that the client is always associated with a particular version (I noticed in version in the spec itself)?

Following the Docker SDKs as an example, the API has a version (we can use the version inside of the spec file). The SDKs are setup to interact with a specific version of the API. Updating the API version reference in the SDK lead to major version bumps of the SDK.

@notthatbreezy
Copy link

Versioning the api client to match the version that is deployed makes sense to me -- and seems to be the convention in Docker right (e.g. python:3.6 is a container with version 3.6.x of python even though this could technically be a different iteration of the client)? If that's what you mean.

I don't think we have been paying attention to the version in the spec itself, but that should probably match the version that is deployed -- even if we don't yet have a versioned API per se.

I can also see the case where there are going to be additions to the API client that should not/would not necessitate deploying new versions of the API. There is quite a bit of catch-up to gain parity with the API I think that we will not want to deploy a new version of the application just to keep in sync.

So maybe in the short term we version the python client separately from our API, but ensure that the releases do not go beyond the application release numbering so we can sync them at a later time.

@hectcastro hectcastro merged commit 9db2a12 into develop May 4, 2017
@hectcastro hectcastro deleted the feature/hmc/init branch May 4, 2017 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants