This repository was archived by the owner on Dec 10, 2019. It is now read-only.
Add scene search, make various fixes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 9, 2017 07:38
- Fixes issue with lists defined for arrays - Adds datasource - Adds geometries - Adds missing scene fields
Bravado spits out irrelevant warnings that we can't fix without handicapping our spec -- it requires a PR to Bravado
Project should not have to be shared in order to export
- project is a UUID - missing query parameters
Users will have to find their own projects, etc. but at least provides an idea for how this should work.
notthatbreezy
force-pushed
the
feature/cmb/add-scene-search
branch
from
fa52cc7 to
b029257
Compare
jisantuc
approved these changes
Aug 9, 2017
There was a problem hiding this comment.
There was a missing parameter from the swagger spec that I added after comparing to requests in going out when trying to add scenes to a project from the UI. Also I allowed get_scenes to take more than just a bbox string as a parameter and included a small example notebook for searching, which is basically just what I did to test the PR.
|
Awesome, thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds scene search, fixes map token serialization