Skip to content
This repository was archived by the owner on Dec 10, 2019. It is now read-only.

Fix install for Mac OS #9

Merged
merged 1 commit into from
May 18, 2017
Merged

Conversation

jisantuc
Copy link
Contributor

Overview

This PR makes it so that ./scripts/update works the same on Mac as it does on Linux.
For some reason, setup.py develop fails to install cryptography, while pip install -e .,
which runs setup.py develop as its last step, succeeds.

Also it relaxed the notebook dependency, since apparently ipyleaflet installs 5.0.0 right
now, and paying the cost to install notebook twice is a draaaaaag.

Testing

  • be on a Mac
  • run ./scripts/update
  • observe success

Fixes #5

@jisantuc jisantuc requested a review from alkamin May 18, 2017 00:59
Copy link
Contributor

@hectcastro hectcastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the updated version of pip is downloading the cryptography wheel, while python setup.py develop is not. Letting modern pip install it via wheel is definitely preferred, so 👍 .

@jisantuc jisantuc merged commit 41f3b0d into develop May 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants