-
Notifications
You must be signed in to change notification settings - Fork 24
adding utf8 encoding to documents data #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding utf8 encoding to documents data #239
Conversation
Hi @MohKamal, thanks for the contribution. Could you check code format? Try using Also, could you provide a simple test that verifies correct behavior? I've seen this one in the codebase, is it passing after the change? Lines 30 to 47 in 6354207
|
@MohKamal To proceed to merge, please address my previous comment - once the test (verifying expected behavior) is created and passing (and the skip is removed from |
Hi @poissoncorp, Thank you for your feedback, I will do it, I was busy a little bit. |
@MohKamal could you amend after |
Yes, done, sorry forgot applying black before pushing! |
To proceed, please fix failing tests. Many thanks 🙏 |
I see that the emojis are correctly saved and retrieved, do i change the test string from "\ud83d\ude21\ud83d\ude21\ud83e\udd2c\ud83d\ude00" to "😡😡🤬😀" ? |
@MohKamal, any idea why those aren't passing? If that's not something critical, we can safely remove that. |
i can escape them ""\ud83d\ude21\ud83d\ude21\ud83e\udd2c\ud83d\ude00" |
I've researched on this myself. Remove the Pythonic \u signs and leave just emojis Like this:
I'll run tests, and merge if passing 👍 |
Encode JSON data as UTF-8 before sending requests to properly support non-ASCII characters.