Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blocked][CRD][3/n] Delete CRD v1alpha1 #1492

Closed

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Oct 13, 2023

Why are these changes needed?

This PR is the step 3 of #1209 (comment).

rm -r apis/ray/v1alpha1

# Update CRD YAMLs
make manifests

# Update CRD YAMLs in the KubeRay operator Helm chart.
make sync

Related issue number

#1481
#1482
#1209

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421 kevin85421 marked this pull request as ready for review October 13, 2023 18:04
Copy link
Member

@hongchaodeng hongchaodeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin85421 kevin85421 changed the title [CRD][3/n] Delete CRD v1alpha1 [Blocked][CRD][3/n] Delete CRD v1alpha1 Oct 13, 2023
@kevin85421 kevin85421 marked this pull request as draft October 13, 2023 21:45
@kevin85421
Copy link
Member Author

[Update]: The Ray Autoscaler fetches information about RayCluster from the Kubernetes API Server. However, it currently has the CRD apiVersion hard-coded to v1alpha1. Therefore, if we remove CRD v1alpha1 in this PR, the Ray Autoscaler will fail to retrieve information from the Kubernetes API server. That's why test-rayservice-sample-yamls-nightly-operator fails consistently.

Screen Shot 2023-10-13 at 2 46 11 PM

[Plan]:

  • v1.0.0, targeted for the end of Oct. 2023, supports Ray 2.4.0 and later versions.
  • KubeRay will release v1.1.0 when Ray releases either Ray 2.9.0 or Ray 2.10.0. From then on, KubeRay v1.1.0 will only support Ray 2.7.1 and subsequent versions.

@kevin85421
Copy link
Member Author

Close this PR in favor of #1771

@kevin85421 kevin85421 closed this Dec 26, 2023
@kevin85421 kevin85421 mentioned this pull request Dec 26, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants