Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support for secure API server build #1749

Merged
merged 5 commits into from
Dec 20, 2023
Merged

added support for secure API server build #1749

merged 5 commits into from
Dec 20, 2023

Conversation

blublinsky
Copy link
Contributor

Why are these changes needed?

For testing we do need to be able to build both secure and insecure versions of app server. Added this support to make file

Related issue number

Checks

  • [x ] I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • [ x] Manual tests
    • This PR is not tested :(

@blublinsky
Copy link
Contributor Author

@z103cb, @tedhtchang, please take a look

cc @kevin85421

z103cb
z103cb reviewed Dec 15, 2023
View reviewed changes
z103cb
z103cb reviewed Dec 15, 2023
View reviewed changes
z103cb
z103cb reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a few sentences to the DEVELOPMENT.md file to cover the new and improved targets? It's probably a miss from the last PR.

z103cb
z103cb reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the small nipicks are addressed, I think this PR will be good to merge.

@z103cb
Copy link
Contributor

z103cb commented Dec 15, 2023

LGTM

@blublinsky
Copy link
Contributor Author

@kevin85421 its ready for you

@kevin85421 kevin85421 merged commit d9a6a92 into ray-project:master Dec 20, 2023
@blublinsky blublinsky deleted the apiserver-make-enchancements branch December 20, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z103cb z103cb z103cb left review comments

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blublinsky @z103cb @kevin85421