[Refactor] Use RAYCLUSTER_DEFAULT_REQUEUE_SECONDS_ENV as timeout of status check in tests #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
force-pushed
the
test-requeue-seconds-env
branch
from
5922f36 to
31a8c2e
Compare
…ut of status check in tests It is only an insurance to keep reconciliation continuously triggered to hopefully fix an unexpected state. Relying on it to fix state transitions is not a good pratice. Therefore, We should not reference it in tests at all.
rueian
force-pushed
the
test-requeue-seconds-env
branch
from
31a8c2e to
b5be747
Compare
|
After discussing with @kevin85421, we think replace all the usages of RAYCLUSTER_DEFAULT_REQUEUE_SECONDS in tests with 15 seconds. Because we should only treat the re-queue of reconciliation as insurance to hopefully fix an unexpected state and we should not rely on it in tests. TODO: We can consider later removing the |
kevin85421
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @kevin85421 found out, we have set
RAYCLUSTER_DEFAULT_REQUEUE_SECONDS_ENVto 10 seconds to speed up the tests. But we still wait forutils.RAYCLUSTER_DEFAULT_REQUEUE_SECONDS+5, which is 305 seconds and is too long, to fail a test.I believe this inconsistency exists because there is no convenient converter for the env variable.
In this PR, I replaced all usages of
RAYCLUSTER_DEFAULT_REQUEUE_SECONDSwithRAYCLUSTER_DEFAULT_REQUEUE_SECONDS_ENVin tests with the help of a simpleMustGetEnvIntconverter.This change can fail our tests faster if any unexpected occurs.
Checks