Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RayService] Remove serve v1 API #1779

Merged
merged 14 commits into from
Dec 29, 2023

Conversation

architkulkarni
Copy link
Contributor

@architkulkarni architkulkarni commented Dec 27, 2023

This is the minimal PR to remove the Serve v1 API, which is removed in Ray 2.9.0.

  • Deleted ServeDeploymentGraphSpec from the RayService CRD, along with its child data structures RayActorOptionSpec and ServeConfigSpec
  • Ran make manifests
  • Ran make sync

Followup work will include

  • Remove the Serve v1 API from apiserver and proto.
  • Delete utils.SINGLE_APP and utils.MULTI_APP and unify the codepaths that used them

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@architkulkarni architkulkarni marked this pull request as ready for review December 29, 2023 00:19
Signed-off-by: Archit Kulkarni <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you double check dashboard_httpclient.go and fake_serve_httpclient.go? I think some functions and variables can also be deleted.

@@ -710,34 +672,14 @@ applications:
})

It("should reconcile status correctly when multi-app config type is used.", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it

Signed-off-by: Archit Kulkarni <[email protected]>
@architkulkarni
Copy link
Contributor Author

Could you double check dashboard_httpclient.go and fake_serve_httpclient.go? I think some functions and variables can also be deleted.

@kevin85421 Yeah, would you prefer to do it all in this PR or is it okay to do it in a followup PR? The current PR is the minimal PR that removes the v1 API.

@architkulkarni
Copy link
Contributor Author

Could you double check dashboard_httpclient.go and fake_serve_httpclient.go? I think some functions and variables can also be deleted.

@kevin85421 Yeah, would you prefer to do it all in this PR or is it okay to do it in a followup PR? The current PR is the minimal PR that removes the v1 API.

I've done this in the following commit on a followup PR: f439814

We can merge this PR and then merge the followup PR, or if you prefer I can just add that commit to this PR.

@kevin85421
Copy link
Member

would you prefer to do it all in this PR or is it okay to do it in a followup PR? The current PR is the minimal PR that removes the v1 API.

Both are fine for me. I like this PR. This PR makes the codebase more elegant!

@kevin85421 kevin85421 merged commit 3c080dc into ray-project:master Dec 29, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants