Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grafana] Update Grafana dashboard #2106

Merged
merged 2 commits into from
May 3, 2024

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Apr 27, 2024

Why are these changes needed?

  1. Upgrade the Ray Grafana dashboard from 2.5.0 to 2.9.0.
  2. Add the Grafana dashboards for Ray Data / Ray Serve.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421 kevin85421 marked this pull request as ready for review April 27, 2024 06:17
@kevin85421 kevin85421 requested a review from jjyao April 29, 2024 18:47
@jjyao
Copy link
Contributor

jjyao commented Apr 29, 2024

What's the context of this PR?

@kevin85421
Copy link
Member Author

What's the context of this PR?

Currently, the Ray dashboard generates Grafana dashboard configurations at runtime. From my perspective, this is unusual behavior. Consequently, users need to copy the JSON configurations from the Ray head Pod and paste them into Grafana to create the dashboard. As a workaround, I also maintain a JSON configuration that users can directly use when following the Ray documentation.

@kevin85421 kevin85421 changed the title [Grafana] Update Grafana dashboard [WIP][Grafana] Update Grafana dashboard Apr 30, 2024
@kevin85421 kevin85421 changed the title [WIP][Grafana] Update Grafana dashboard [Grafana] Update Grafana dashboard Apr 30, 2024
@kevin85421 kevin85421 changed the title [Grafana] Update Grafana dashboard [WIP][Grafana] Update Grafana dashboard May 2, 2024
@kevin85421 kevin85421 marked this pull request as draft May 2, 2024 17:09
@kevin85421
Copy link
Member Author

Convert it to draft. I will update the config to Ray 2.20 after I update the sample YAMLs to use Ray 2.20 images.

@kevin85421 kevin85421 marked this pull request as ready for review May 3, 2024 00:35
@kevin85421
Copy link
Member Author

Ray 2.20.0 has some issues, so I will not upgrade KubeRay to use Ray 2.20.0 by default. See https://ray-distributed.slack.com/archives/C02GFQ82JPM/p1714683469966249 for more details. Merge this PR.

@kevin85421 kevin85421 changed the title [WIP][Grafana] Update Grafana dashboard [Grafana] Update Grafana dashboard May 3, 2024
@kevin85421 kevin85421 merged commit e89ae34 into ray-project:master May 3, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants