Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Improve perf-test YAMLs and README #2110

Merged
merged 1 commit into from
May 1, 2024

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented May 1, 2024

Why are these changes needed?

TODO:

  • Prometheus metrics
  • If RayJob custom resources cannot complete indefinitely due to the lack of gang scheduling, it appears that the clusterloader process does not time out even after 20 minutes.

Related issue number

#2102

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

I modified the script a bit to create 10 RayJob CRs on my local Kind cluster.

Screenshot 2024-04-30 at 10 02 33 PM Screenshot 2024-04-30 at 10 04 24 PM

helm install kuberay-operator kuberay/kuberay-operator --version 1.1.0
```

Run a clusterloader2 test:
```sh
clusterloader2 --provider kind --kubeconfig ~/.kube/config --testconfig ./100-rayjob/config.yaml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I think most people can't launch 100 RayCluster custom resources on local Kind cluster, I use RayJob instead.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense since 100 rayjobs will shutdown after completion so it does't have to run all at once

@kevin85421 kevin85421 marked this pull request as ready for review May 1, 2024 05:17
@kevin85421
Copy link
Member Author

cc @andrewsykim

Copy link
Collaborator

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@kevin85421 kevin85421 requested a review from jjyao May 1, 2024 15:18
@kevin85421 kevin85421 merged commit b5f237d into ray-project:master May 1, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants