use rustix for _IO generator macros - #118
Open
habnabit wants to merge 1 commit into
Open
Conversation
this would use libc but for rust-lang/libc#1662
habnabit
force-pushed
the
use-rustix-ioc
branch
from
October 15, 2024 12:19
6e71818 to
ddfc255
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this would use libc but for rust-lang/libc#1662
it failed for me on mipsel, which has
_IOC_SIZEBITS = 13. instead of trying to replicate platform special-case behavior in here that already exists elsewhere, use rustix. there's likely already a dependency on rustix somewhere else in the tree. the exact version could be pinned much earlier. but, here's an idea.