Remove unnecessary lifetime parameters - #122
Open
riverbl wants to merge 1 commit into
Open
Conversation
Remove lifetime parameter from `mmap::Arena`. The memory annotated with this lifetime is managed by the `Arena` object itself, so there is no need for an external lifetime. Remove lifetime parameters from `CaptureStream` and `OutputStream`. These lifetimes are only used by the `next` method, where the explicit lifetimes are the same as those that would have been inferred.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mmap::Arenahas a lifetime parameter, but as far as I can tell the memory this refers to ismmaped device memory managed by theArenaobject itself. This memory is only unmapped when theArenais dropped, so will remain valid for the lifetime of theArenaobject, so I don't see any need for an external lifetime.The
CaptureStreamandOutputStreamtraits have lifetime parameters, but they are only used by thenextmethod, where the explicit lifetimes are the same as those that would have been inferred.This PR removes all of the above lifetime parameters.