Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideCorrects the JetPack version mapping for a specific L4T release (38.4.0) in the Jetson variables configuration to match NVIDIA’s official JetPack archive. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `jtop/core/jetson_variables.py:49` </location>
<code_context>
NVIDIA_JETPACK = {
# -------- JP7 --------
- "38.4.0": "7.2",
- "38.3.0": "7.1",
+ "38.4.0": "7.1",
"38.2.2": "7.0",
</code_context>
<issue_to_address>
**question (bug_risk):** Dropping the 38.3.0 mapping may break lookups for that L4T version.
With this entry removed, any lookup of JetPack from L4T 38.3.0 will fail or hit a fallback, depending on how this dict is consumed. If 38.3.0 is still supported or used, consider keeping this mapping or adding explicit handling for that version to preserve predictable behavior.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
johnnynunez
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jetpack version corresponding to L4T r38.4 should be 7.1
JetPack Archive
Summary by Sourcery
Bug Fixes: