Skip to content

install: ensure jtop group exists for no-sudo setup#795

Merged
johnnynunez merged 1 commit intorbonghi:masterfrom
whitesscott:install-sh-add-group-jtop
Jan 23, 2026
Merged

install: ensure jtop group exists for no-sudo setup#795
johnnynunez merged 1 commit intorbonghi:masterfrom
whitesscott:install-sh-add-group-jtop

Conversation

@whitesscott
Copy link
Contributor

@whitesscott whitesscott commented Jan 22, 2026

On a freshly re-flashed Jetson Thor, jtop.service did not start until I ran: sudo groupadd -f jtop.

Add 'sudo groupadd -f jtop' to scripts/install_jtop_torun_without_sudo.sh to ensure the group exists and improve first-run reliability.

Summary by Sourcery

Enhancements:

  • Add a step in the no-sudo jtop installation script to create the jtop group if it does not already exist.

On a freshly re-flashed Jetson Thor, jtop.service did not start until I ran: sudo groupadd -f jtop.

Add 'sudo groupadd -f jtop' to scripts/install_jtop_torun_without_sudo.sh to ensure the group exists and improve first-run reliability.
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 22, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensures the jtop Unix group is created during the no-sudo installation flow to prevent jtop.service from failing to start on fresh Jetson Thor systems.

Flow diagram for updated jtop no-sudo install script

flowchart TD
  A[Start install_jtop_torun_without_sudo.sh] --> B[Check prerequisites and environment]
  B --> C[Set PATH to include HOME/.local/bin]
  C --> D[Run sudo groupadd -f jtop]
  D --> E[Echo Creating Python virtual environment]
  E --> F[Run uv venv VENV_DIR -p python3.12 --seed]
  F --> G[Continue remaining install steps]
  G --> H[End]
Loading

File-Level Changes

Change Details Files
Ensure the jtop group is created as part of the no-sudo jtop installation script.
  • Add a pre-venv step to create the jtop Unix group if it does not already exist using groupadd -f jtop.
  • Keep the rest of the installation flow (PATH export and venv creation) unchanged.
scripts/install_jtop_torun_without_sudo.sh

Possibly linked issues

  • #Access to jtop.service by non root users: PR ensures jtop group exists in no-sudo install script, directly addressing non-root access to jtop.service.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@whitesscott whitesscott marked this pull request as ready for review January 22, 2026 01:47
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@johnnynunez johnnynunez merged commit ba634f0 into rbonghi:master Jan 23, 2026
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants