nondisjunction-lines #114
Merged
nondisjunction-lines #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR relates to the discussion in #98 following project board review in August which sought to clarify the disjunctions in UK-WHO in height/length and BMI as well as OFC. Although these are signposted with tooltips, this is further highlighted by vertical lines and text.
Code changes
nondisjunctionLines.tsis introduced which defines the x value cutoffs and label text for each disjunctionmakeAllStylesadds two more shades of greyDocumentation changes (done or required as a result of this PR)
No implications for documentation
Related Issues
closes #98