Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase-measurement-pointsize #95

Merged
merged 2 commits into from
Jul 21, 2024
Merged

increase-measurement-pointsize #95

merged 2 commits into from
Jul 21, 2024

Conversation

eatyourpeas
Copy link
Member

Overview

observation the in v7.0.0 the plotted points appear smaller.

Code changes

Measurement points are dynamically sized and this code has not changed since v.6 so it is not clear why they look smaller now. I have increased the default size of chronological and corrected plots to 3.5pt though this reduces to 1.5 if points are crowded.

There is no user prop for this and I am inclined to keep this definition as a core chart style.

Related Issues

closes #94

Mentions

@dmc-cambric

@eatyourpeas eatyourpeas added the consistency Not strictly a bug, but an implementation could be made clearer label Jul 21, 2024
@eatyourpeas eatyourpeas self-assigned this Jul 21, 2024
@eatyourpeas eatyourpeas merged commit 07f1af8 into live Jul 21, 2024
2 checks passed
@eatyourpeas eatyourpeas deleted the eatyourpeas/issue94 branch July 21, 2024 12:05
@mbarton
Copy link
Member

mbarton commented Jul 22, 2024

@eatyourpeas could you add a before/after image comparison please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consistency Not strictly a bug, but an implementation could be made clearer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Measurement points smaller since v7.0.0
2 participants