Skip to content

Commit

Permalink
Merge pull request #654 from rcpch/mbarton/fix-dashboard-error
Browse files Browse the repository at this point in the history
Don't log error for dashboard if no data uploaded yet
  • Loading branch information
mbarton authored Feb 23, 2025
2 parents 80c172f + f7a6baa commit cb1a750
Showing 1 changed file with 5 additions and 15 deletions.
20 changes: 5 additions & 15 deletions project/npda/general_functions/map.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,27 +60,17 @@ def get_children_by_pdu_audit_year(
Patient = apps.get_model("npda", "Patient")
Submission = apps.get_model("npda", "Submission")

try:
submission = Submission.objects.filter(
audit_year=audit_year,
paediatric_diabetes_unit=paediatric_diabetes_unit,
submission_active=True,
).get()
except Submission.DoesNotExist:
logger.error(
f"No active submission found for audit year {audit_year} and Paediatric Diabetes Unit {paediatric_diabetes_unit}"
)
return Patient.objects.none()
submission = Submission.objects.filter(
audit_year=audit_year,
paediatric_diabetes_unit=paediatric_diabetes_unit,
submission_active=True,
).first()

if submission is None:
return Patient.objects.none()

patients = submission.patients.all()

print(
audit_year, paediatric_diabetes_unit, paediatric_diabetes_unit_lead_organisation
)

if patients:
filtered_patients = patients.filter(
~Q(postcode__isnull=True)
Expand Down

0 comments on commit cb1a750

Please sign in to comment.